Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment_Engine: Panels by level filter #1106

Merged
merged 3 commits into from
Jul 19, 2019
Merged

Environment_Engine: Panels by level filter #1106

merged 3 commits into from
Jul 19, 2019

Conversation

FraserGreenroyd
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd commented Jul 19, 2019 •
edited
Loading

Issues addressed by this PR

Fixes #1105

Test files

Being developed - but feel free to test on existing scripts

Changelog

  • Added ability to filter Environment Panels by level

#1105 - panels by level filter
f11960e 
Sneaky fix to minimum and maximum levels rounding to 3dp
@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Jul 19, 2019
@FraserGreenroyd FraserGreenroyd self-assigned this Jul 19, 2019
tg359
tg359 approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a user input in the future for how much to round an XYZ point value by. Just in case something occurs where we need a bit more accuracy/use a different unit.

@FraserGreenroyd FraserGreenroyd merged commit 5fd2bf1 into master Jul 19, 2019
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-Issue1105 branch July 19, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg359 tg359 tg359 approved these changes

@michaldengusiak michaldengusiak Awaiting requested review from michaldengusiak

@mariatjader mariatjader Awaiting requested review from mariatjader

@vbeardow vbeardow Awaiting requested review from vbeardow

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Find panels by level
2 participants
@FraserGreenroyd @tg359