Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: Convert.toNurbsCurve(Arc) #960

Closed
alexradne opened this issue May 16, 2019 · 5 comments · Fixed by #1283
Closed

Geometry_Engine: Convert.toNurbsCurve(Arc) #960

alexradne opened this issue May 16, 2019 · 5 comments · Fixed by #1283
Assignees

Comments

@alexradne
Copy link
Member

The method Convert.toNurbsCurve(Arc) is needed for the Extrude(Bar) method to show sections with rounded profiles.
Out of curiosity I spent an hour to research Nurbcurves and implement this.

But It seems like we can't display extrusion geometries in grasshopper yet. So it does not solve it completely yet

alexradne added a commit that referenced this issue May 16, 2019
Implemented toNurbsCurve(Arc) and Tranform(NurbsCurve)
fixes #960
@alexradne
Copy link
Member Author

How to create a circle segment nurbs curve:
https://pages.mtu.edu/~shene/COURSES/cs3621/NOTES/spline/NURBS/RB-circles.html

Test Script:
In test scripts folder

@epignatelli
Copy link
Member

I think it's time we can discuss about introducing two resolutions of rendering in the UI (at least in Grasshopper): the physical resolution and the analytical resolution.

e.g. a bar has a line as analytical geometry, a T-shaped extrusion as physical geometry
@al-fisher @rwemay @adecler @IsakNaslundBh @FraserGreenroyd any thought?

@IsakNaslundBh
Copy link
Contributor

IsakNaslundBh commented May 20, 2019

Think we had this already, at least we did have it at one point. Can be worth looking through some old commits for the code.

EDIT: here:

ee1643f#diff-4d3e0b17ced26bb9f91e2f284a923b9c

@IsakNaslundBh
Copy link
Contributor

and @epignatelli I agree. In terms of visualisation we already have (or at least had) two options, extruded or centre line. Right now the Geometry() method for both the framingelements and the bars return the centreline geometry, as often more useful and significantly lighter. If something else is wanted (extruded) you have to call it explicitly.

Are you envisaging some global setting or something else?

@epignatelli
Copy link
Member

Yes, it was one of my though to replicate the grasshopper behaviour of "wireframe" or "meshes" rendering. Do you see the need from the designer point of view?

I'd rather not overriding the normal grasshopper behaviour - we might want to display meshes of grasshopper objects and wireframe of bhom objects.
It may be just a component you drop on the canvas that modifies the behaviour or an entry in the grasshopper menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants