Add null perimeter space output to IsValidSpaces

BHoM · Dec 2, 2022 · 17ced89 · 17ced89
1 parent dadc6f2
commit 17ced89
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/Environment_Engine/Query/IsValid.cs b/Environment_Engine/Query/IsValid.cs
@@ -45,6 +45,7 @@ public static partial class Query
         [MultiOutput(1, "selfIntersectingSpaces", "Returns list of invalid spaces due to the perimeter curve self intersecting.")]
         [MultiOutput(2, "zeroPerimeterSpaces", "Returns list of invalid spaces due to perimeter length being zero.")]
         [MultiOutput(3, "notClosedSpaces", "Returns list of invalid spaces due to not closed perimeter.")]
+        [MultiOutput(4, "nullPerimeterSpaces", "Returns list of invalid spaces due to having a null perimeter.")]
         public static Output<List<Space>, List<Space>, List<Space>, List<Space>> IsValid(this List<Space> spaces, double intersectionTolerance = BH.oM.Geometry.Tolerance.Distance, double lengthTolerance = BH.oM.Geometry.Tolerance.Distance, double closedSpacesTolerance = BH.oM.Geometry.Tolerance.Distance)
         {
             if(spaces == null)
@@ -57,10 +58,18 @@ public static Output<List<Space>, List<Space>, List<Space>, List<Space>> IsValid
             List<Space> selfIntersectingSpaces = new List<Space>();
             List<Space> zeroPerimeterSpaces = new List<Space>();
             List<Space> notClosedSpaces = new List<Space>();
+            List<Space> nullPerimeterSpaces = new List<Space>();
+
             foreach (Space space in spaces)
             {
                 if(space == null)
                     continue;
+
+                if(space.Perimeter == null)
+                {
+                    nullPerimeterSpaces.Add(space);
+                    continue; //Don't run the rest of the loop and risk it crashing on the other checks if the perimeter is null
+                }
 
                 bool isvalid = true;
                 if (space.IsSelfIntersecting(intersectionTolerance))