Update US_SteelSection values with high diff

[Martian42]

NOTE: Depends on

Issues addressed by this PR

Closes #157

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/BHoM_Datasets/%23157-Correct%20US%20steel%20section%20properties%20with%20larger%20than%202%20percent%20difference?csf=1&web=1&e=pyIwrm

Changelog

Additional comments

The inaccuracy is from the catalogue side. All values which is higher than 2% diff between BHoM and catalogue value has been updated to BHoM value.

Added @NikotaLitzin to review from a US perspective. Note that their is a v16.0 for AISC Shapes Databsase (this Dataset is based on v15.0). For the purpose of this PR lets review the shape profiles being modified, and then we can update to v16.0 seprately.

[peterjamesnugent]

@BHoMBot check dataset-compliance

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check dataset-compliance

There are 24 requests in the queue ahead of you.

[peterjamesnugent]

Happy to approve this - the /develop branch has nearly 300 properties above the 2% threshold - so great that this has been picked up to highlight errors in the source data. We should highlight this to the AISC so they can update their catalouges.

I do get some above 2% but on inspection the numbers are exactly the same, despite no rounding (and the numbers are small enough that differences are miniscule):

[peterjamesnugent]

@BHoMBot check required

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

outdated

[peterjamesnugent]

@Martian42, I believe you have serialised the Dataset with rounded values, can you reserialise the dataset without any rounding please so it is identical between the BHoMDataset and our Integration methods (otherwise we are just adding a %Diff for no reason).

[Martian42]

@Martian42, I believe you have serialised the Dataset with rounded values, can you reserialise the dataset without any rounding please so it is identical between the BHoMDataset and our Integration methods (otherwise we are just adding a %Diff for no reason).

Thanks @peterjamesnugent, correctly formatted the BHoM values, test script no longer showing anything over 2% diff!

[peterjamesnugent]

@BHoMBot check compliance

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[peterjamesnugent]

@BHoMBot check ready-to-merge

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check ready-to-merge

There are 6 requests in the queue ahead of you.

[peterjamesnugent]

Happy changes have been made and values > 2% deviance have been updated. As mentioned earlier, worth reaching out to the source of the data to update their catalouge.

[peterjamesnugent]

@BHoMBot check ready-to-merge

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check ready-to-merge

[peterjamesnugent]

@BHoMBot check required

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 4 requests in the queue ahead of you.

[peterjamesnugent]

@BHoMBot check ready-to-merge

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check ready-to-merge

There are 9 requests in the queue ahead of you.

[IsakNaslundBh]

Before this is being merged, can it please be reviewd by a US engineer. I seem to remeber that when these dataset where first generated, this difference was found, but that the decision made back then was to keep the catalogue values, as that is what is the more defining metric for a particular section, rather than the exact dimensions down to the last root radius.

Before moving away from these catalogue values, I think that it needs to be confirmed by a US structural engineer with enough experience.

[IsakNaslundBh]

For not to elaborate reference on the above, please see #5 (review)