Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Assembly Information #321

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Conversation

FraserGreenroyd
Copy link
Contributor

Update Assembly Information to include description

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 18, 2022

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 18, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

There are 8 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jul 18, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Jul 18, 2022
@FraserGreenroyd FraserGreenroyd requested a review from alelom July 18, 2022 22:37
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check versioning
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check versioning
  • check core
  • check null-handling
  • check serialisation

There are 1478 requests in the queue ahead of you.

alelom
alelom previously approved these changes Jul 19, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2022

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 7405578565

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot fix project file ref. 7405578565

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2022

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 323 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2022

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2022

@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge, installer, serialisation, versioning, null-handling, copyright-compliance, core, documentation-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 7fba724 into main Jul 19, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM-UpdateAssemblyInformation branch July 19, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants