Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align to changes on Diffing #268

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Align to changes on Diffing #268

merged 2 commits into from
Dec 2, 2020

Conversation

alelom
Copy link
Member

@alelom alelom commented Nov 16, 2020

NOTE: Depends on

BHoM/BHoM_Engine#2105

Issues addressed by this PR

Closes #267

Test files

Changelog

Additional comments

@alelom alelom self-assigned this Nov 16, 2020
@alelom alelom added the type:compliance Non-conforming to code guidelines label Nov 16, 2020
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 17, 2020

@FraserGreenroyd to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

FraserGreenroyd
FraserGreenroyd reviewed Nov 22, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good in alignment with the other PRs, I would be happy to convert this to approving once the other PRs are in line 😄

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 1, 2020

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 1, 2020

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 1, 2020

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

/azp run BHoM_Adapter.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2020

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM_Engine

@FraserGreenroyd FraserGreenroyd merged commit 6f57547 into master Dec 2, 2020
@FraserGreenroyd FraserGreenroyd deleted the Diffing_Engine-#2095-leveragePersistentId branch December 2, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

@rolyhudson rolyhudson Awaiting requested review from rolyhudson

Assignees

@alelom alelom

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align to changes required on Diffing
2 participants
@alelom @FraserGreenroyd