Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BHoM_Adapter: Update AssemblyFileVersion, set CopyLocal to false #130

Merged
merged 2 commits into from
Sep 18, 2019
Merged

BHoM_Adapter: Update AssemblyFileVersion, set CopyLocal to false #130

merged 2 commits into from
Sep 18, 2019

Conversation

alelom
Copy link
Member

@alelom alelom commented Sep 16, 2019 •
edited
Loading

Closes #132

Changelog

  • Update AssemblyFileVersion to 2.4.0.0
  • Set CopyLocal to False

@alelom alelom changed the title BHoM_ADA: Update AssemblyFileVersion to 2.4.0.0 BHoM_Adapter: Update AssemblyFileVersion to 2.4.0.0 Sep 16, 2019
@alelom alelom self-assigned this Sep 16, 2019
@alelom alelom added the type:compliance Non-conforming to code guidelines label Sep 16, 2019
@alelom alelom added this to the BHoM 2.4 β RC milestone Sep 16, 2019
@alelom alelom changed the title BHoM_Adapter: Update AssemblyFileVersion to 2.4.0.0 BHoM_Adapter: Update AssemblyFileVersion, set CopyLocal to false Sep 18, 2019
FraserGreenroyd
FraserGreenroyd requested changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the pure basis that this PR does not have an issue attached to it I feel I must request a change of including an issue this PR is resolving 😉

Otherwise, LGTM and happy to approve once there is transparency over the work being done 😄

FraserGreenroyd
FraserGreenroyd approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alelom 😄

@alelom alelom merged commit 7506944 into master Sep 18, 2019
@alelom alelom deleted the UpdateAssemblyFileVersionTo2.4.0.0 branch October 30, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

Assignees

@alelom alelom

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 2.4 β RC
Development

Successfully merging this pull request may close these issues.

Update AssemblyFileVersion to 2.4.0.0, set CopyLocal to False
2 participants
@alelom @FraserGreenroyd