Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up project loading #48

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Speed up project loading #48

merged 1 commit into from
Oct 3, 2022

Conversation

FraserGreenroyd
Copy link

@FraserGreenroyd FraserGreenroyd commented Oct 3, 2022 •
edited
Loading

Issues addressed by this PR

Fixes #46

Test files

Changelog

Additional comments

We may be able to do more but for now this should improve speed somewhat.

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Oct 3, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Oct 3, 2022
@FraserGreenroyd
Copy link
Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

travispotterBH
travispotterBH approved these changes Oct 3, 2022
View reviewed changes
Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unblocking to allow general testing of improvements

@FraserGreenroyd
Copy link
Author

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit e30c17d into main Oct 3, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoMAnalytics_Toolkit-#46-LoadingTime branch October 3, 2022 19:09
@FraserGreenroyd FraserGreenroyd changed the title Speed up project loading #46 Speed up project loading Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travispotterBH travispotterBH travispotterBH approved these changes

@alexissantella alexissantella Awaiting requested review from alexissantella

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popup loading time is more than 5 seconds
2 participants
@FraserGreenroyd @travispotterBH