Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Window Positions to Center Screen #40

Conversation

travispotterBH
Copy link

@travispotterBH travispotterBH commented Sep 16, 2022

Issues addressed by this PR

Closes #39

Window position set to CenterScreen to alleviate issues with window pop-up appearing in nonsensical locations.

Changelog

  • CaptureProjectData.xaml - Window position set to CenterScreen to alleviate issues with window pop-up appearing in nonsensical locations.

Additional comments

@rboulton-BH can you test this on your machine with multiple monitors and report back the results? I am only on my laptop today and the window does in fact appear at the center of my screen no matter the UI, but I would love to see how it behaves on multiple monitor setups. Please include a gif using screentogif thanks!

@FraserGreenroyd
Copy link

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 16, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 6 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 16, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 16, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this deployed for easy testing via installers. Happy with the change, will be intriguing to see what comes back feedback wise.

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 16, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 3bf63df into main Sep 16, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoMAnalytics_Toolkit-#39-WindowDoesNotShowUpAtCenterOfScreenOrCenterOfApp branch September 16, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window does not show up at center of screen or center of app
4 participants