Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnOffsetsCommitted event handler not called when IsAutoCommitEnabled = false #167

Closed
matthewdavena opened this issue Jun 16, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@matthewdavena
Copy link

Hi,
when I configure the Kafka consumer with IsAutoCommitEnabled = false, the OnOffsetsCommitted handler is not called.
Is this a bug or is it by design? I had assumed that the event would be raised for any commit mode, automatic or manual.

Thanks in advance,
Matteo

@BEagle1984
Copy link
Owner

You are right. The underlying Confluent.Kafka library doesn't call the handler if you are manually committing, but when using Silverback you would expect it to be called (since you aren't manually committing, Silverback is doing it).
I will implement that. Thanks!

@BEagle1984 BEagle1984 added the bug Something isn't working label Jun 17, 2022
@matthewdavena
Copy link
Author

Thanks!

@BEagle1984
Copy link
Owner

Fixed in v3.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants