Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various property widgets use classic button style #1191

Closed
vrad-exe opened this issue Oct 13, 2019 · 6 comments · Fixed by #1209
Closed

Various property widgets use classic button style #1191

vrad-exe opened this issue Oct 13, 2019 · 6 comments · Fixed by #1209
Labels
Bug Something isn't working correctly Done in next release This has been addressed in the next release Enhancement Improvement or tweak to the mod Windows Issue only applies to Windows

Comments

@vrad-exe
Copy link
Member

Similarly to #1148, the slider and timer widgets in the Item Properties pane still use the old beveled style from Windows 95.
image
Modern sliders look like this:
image
And here's a modern timer (well not used as a timer here, but the layout is the same):
image
For reference, both of these can be found in the mouse properties menu in Control Panel.

@vrad-exe vrad-exe added Bug Something isn't working correctly Enhancement Improvement or tweak to the mod Windows Issue only applies to Windows labels Oct 13, 2019
@vrad-exe
Copy link
Member Author

This also affects the piston platform height sliders (and possibly other properties) in Change Defaults:
image
Oddly, the Timer Delay option actually uses a modern slider, though not the same one I showed in my original image. This one has a taller bar, and no tick marks.
image

@vrad-exe
Copy link
Member Author

Color pickers also use the old style. I don't know of any modern version of this, though it should be pretty easy to make a custom one (pretty much the same thing just with no bevel, and maybe a bit bigger).
image

@vrad-exe vrad-exe changed the title Slider and timer widgets use classic button style Various property widgets use classic button style Oct 13, 2019
@TeamSpen210
Copy link
Member

Basically, Tkinter (the widget toolkit I'm using) has two sets of widgets - the original set, which always have the same appearance (from that sorta era), and a themed set, which matches the OS but can't be customised as much necessarily. In some cases I have to use the former for a feature or something. It looks like for these I'm not though so I can switch them across. The color pickers are actually just a "text label" with a custom background. I can remove the 3D effect.

@TeamSpen210 TeamSpen210 added the Done in next release This has been addressed in the next release label Oct 15, 2019
@TeamSpen210
Copy link
Member

Fixed, excluding the timer widget (which doesn't allow you to type in the number properly).

@vrad-exe
Copy link
Member Author

What do you mean?

@TeamSpen210
Copy link
Member

I have a special validator set which allows you to type into the Item Properties timers, disallowing invalid characters. But if I use the themed version it doesn't work and typing into the box becomes entirely wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working correctly Done in next release This has been addressed in the next release Enhancement Improvement or tweak to the mod Windows Issue only applies to Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants