Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an intelligent system to prevent Retro Mandatory Observations from showing nodraw when duplicated #2583

Closed
CubieJudy opened this issue Mar 22, 2018 · 10 comments · Fixed by #2855 or BEEmod/BEE2.4#1017
Labels
Bug Something isn't working correctly Enhancement Improvement or tweak to the mod Old Aperture Issue only applies to one or more Old Aperture styles.

Comments

@CubieJudy
Copy link

CubieJudy commented Mar 22, 2018

The duplicated Mandatory Observations should still be included in the builded map, but with an intelligent system to prevent them from showing nodraw by using another skybox as HugoBDesigner suggested, or other type of geometry design inside them.

20180322105601_1
20180322105610_1
20180322105619_1
20180322105623_1

@CubieJudy
Copy link
Author

Nvm. Had to change styles. Sorry for wasting time

@HugoBDesigner
Copy link
Member

The changing of styles doesn't really stop the bug from happening.

@HugoBDesigner HugoBDesigner reopened this Mar 22, 2018
@HugoBDesigner HugoBDesigner added Bug Something isn't working correctly Old Aperture Issue only applies to one or more Old Aperture styles. Leak labels Mar 22, 2018
@villager103
Copy link

If i'm not mistaken, using multiple of those grated observation rooms causes issues because they use worldportals to show the enrichment sphere. There's a stylevar that changes them to normal observation rooms, or you could use regular rooms instead.

@FrozenDragon0
Copy link
Member

@King0191 Yes do not use multiple large observation rooms in underground since they all use world portals and multiple of them can cause leaks perhaps switch to the other ones like @villager103 said.

@vrad-exe
Copy link
Member

That wouldn't cause any leaks, although it would cause nodraw to appear behind the grating.

@helderbarboza
Copy link
Contributor

do not use multiple large observation rooms in underground since they all use world portals and multiple of them can cause leaks

There should be an alert on BEE2, if it does not exists already.
Maybe causing map editor to fail during compilation?

@HugoBDesigner
Copy link
Member

There should be an alert on BEE2, if it does not exists already.
Maybe causing map editor to fail during compilation?

Perhaps, instead, it'd be better to have the compiler detect those and only make one (or none) of the worldportals actually work. Or perhaps replace them with a skybox?

@LautaroL20
Copy link
Member

The duplicated Mandatory Observations should still be included in the builded map, but with an intelligent system to prevent them from leaking by using another skybox as HugoBDesigner suggested, or other type of geometry design inside them.

Respect to other mandatory duplicated items in the map such as entry and exit doors i am totally agree that these should be excluded from appearing since otherwise would not make any sense asides from look messy.

I will open an issue containing the first exposed on the mandatory observation.

@LautaroL20 LautaroL20 changed the title Strange Leak in 1960's stage Implement an intelligent system to prevent Retro Mandatory Observations from leaking when duplicated Mar 24, 2018
@LautaroL20
Copy link
Member

I think its perfectly fine to merge the idea directly here.

@LautaroL20 LautaroL20 added the Enhancement Improvement or tweak to the mod label Mar 24, 2018
@vrad-exe vrad-exe changed the title Implement an intelligent system to prevent Retro Mandatory Observations from leaking when duplicated Implement an intelligent system to prevent Retro Mandatory Observations from showing nodraw when duplicated Mar 24, 2018
@vrad-exe vrad-exe removed the Leak label Mar 30, 2018
@LautaroL20 LautaroL20 added Implemented Done in next release This has been addressed in the next release labels Oct 30, 2018
@LautaroL20
Copy link
Member

Nice, this has been implemented.

This was referenced Nov 10, 2018
@TeamSpen210 TeamSpen210 removed the Done in next release This has been addressed in the next release label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working correctly Enhancement Improvement or tweak to the mod Old Aperture Issue only applies to one or more Old Aperture styles.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants