Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate reference parameters to allow non-genbank file formats #6

Merged
merged 9 commits into from
Dec 27, 2023
Merged

separate reference parameters to allow non-genbank file formats #6

merged 9 commits into from
Dec 27, 2023

Conversation

jpalmer37
Copy link
Contributor

@jpalmer37 jpalmer37 commented Dec 13, 2023 •
edited
Loading

Fixes as described in #7

@jpalmer37 jpalmer37 changed the title merge dev into main (or other branch) separate reference parameters to allow non-genbank file formats Dec 13, 2023
@dfornika dfornika requested a review from j3551ca December 13, 2023 20:50
j3551ca
j3551ca requested changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@j3551ca j3551ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great - can you update the readme to reflect the concatenated vs. segmented modes before we merge ?

@jpalmer37
Copy link
Contributor Author

Of course! I'll do that shortly. Thanks Jess!

@jpalmer37
Copy link
Contributor Author

README has been updated 👍

@j3551ca j3551ca merged commit 16878b9 into BCCDC-PHL:main Dec 27, 2023
@j3551ca
Copy link
Collaborator

j3551ca commented Dec 27, 2023

Thanks, John!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j3551ca j3551ca j3551ca requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpalmer37 @j3551ca