Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE #716 - use decorators and remove deprecated features #717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

git-tirthankar
Copy link

@git-tirthankar git-tirthankar commented Jan 28, 2024

Describe your changes

removed deprecated features and new decorators auto_get_source and auto_finalize as per: https://bc-security.gitbook.io/empire-wiki/module-development/powershell-modules#decorators

Issue ticket number and link (if there is one)

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I have added an entry to CHANGELOG.md
  • I have updated the documentation in docs/ (if applicable)

@vinnybod
Copy link

vinnybod commented Jan 28, 2024

Changes look good to me, thanks!
Can you run the linting/formatting so the CI can run all the way through?

https://github.com/BC-SECURITY/Empire/blob/main/.github/CONTRIBUTING.md#code-formatting-and-linting

If you install pre-commit, you can run it on your previous commit with pre-commit run --from-ref HEAD~ --to-ref HEAD

@D3vil0p3r
Copy link

@git-tirthankar what about this PR? Can you give a look to @vinnybod request please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants