Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.2 #652

Merged
merged 2 commits into from
Nov 18, 2021
Merged

v0.5.2 #652

merged 2 commits into from
Nov 18, 2021

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Nov 17, 2021

Changes

Release 0.5.2

Checks

  • create a PR that finalizes the code for the next version
    • name the PR according to the version vX.Y.Z and add the release
      tag (example here)
    • make sure CHANGELOG.rst is up to date and enter current date to the release version
    • add summarized release highlights where appropriate
    • update the CITATION.cff version number and date
    • search the project for deprecated and remove deprecated code
  • CI jobs to finish
  • wait for review
  • check the readthedocs PR build

@github-actions
Copy link

github-actions bot commented Nov 17, 2021

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 3s ⏱️ +35s
1 936 tests ±0  1 936 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8334715. ± Comparison against base commit 895e03e.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@marscher marscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand why we have three spaces indention after an enumeration 👍

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #652 (8334715) into master (895e03e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #652   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          93       93           
  Lines        6050     6050           
=======================================
  Hits         5718     5718           
  Misses        332      332           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895e03e...8334715. Read the comment docs.

@CagtayFabry
Copy link
Member Author

I do not understand why we have three spaces indention after an enumeration 👍

me neither but it comes out of rstfmt so I will just let it do it's thing 😉

@CagtayFabry CagtayFabry merged commit 108084c into master Nov 18, 2021
@CagtayFabry CagtayFabry deleted the v0.5.2 branch November 18, 2021 09:29
@marscher
Copy link
Collaborator

I see. Do we have rstfmt in our CI pipeline?

@CagtayFabry
Copy link
Member Author

no it seems to be pretty stale, I only use it for the changelog once every while anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants