Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csm.__eq__ now generically checks all node and edge attributes #648

Merged
merged 5 commits into from
Nov 17, 2021

Conversation

marscher
Copy link
Collaborator

@marscher marscher commented Nov 16, 2021

Changes

csm.eq now generically checks all node and edge attributes. This includes transformations and data.

Related Issues

Closes #395

Checks

  • updated tests

@CagtayFabry CagtayFabry added the transformations everything related to the LCS / CSM label Nov 16, 2021
@github-actions
Copy link

github-actions bot commented Nov 16, 2021

Unit Test Results

       1 files  ±0         1 suites  ±0   1m 26s ⏱️ -22s
1 936 tests +1  1 936 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit 7ef7684. ± Comparison against base commit 37535aa.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #648 (ef53145) into master (37535aa) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head ef53145 differs from pull request most recent head 7ef7684. Consider uploading reports for the commit 7ef7684 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
- Coverage   94.52%   94.50%   -0.02%     
==========================================
  Files          93       93              
  Lines        6042     6021      -21     
==========================================
- Hits         5711     5690      -21     
  Misses        331      331              
Impacted Files Coverage Δ
weldx/transformations/cs_manager.py 98.77% <100.00%> (-0.02%) ⬇️
weldx/asdf/file.py 96.04% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37535aa...7ef7684. Read the comment docs.

Copy link
Collaborator

@vhirtham vhirtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

weldx/tests/transformations/test_cs_manager.py Outdated Show resolved Hide resolved
@marscher marscher merged commit 895e03e into BAMWelDX:master Nov 17, 2021
@marscher marscher deleted the csm_eq_consider_data branch November 17, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed transformations everything related to the LCS / CSM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSM.__eq__ does not consider attached data
3 participants