Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.0 #575

Merged
merged 14 commits into from
Oct 12, 2021
Merged

v0.5.0 #575

merged 14 commits into from
Oct 12, 2021

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Oct 1, 2021

create release PR

  • create a PR that finalizes the code for the next version
    • name the PR according to the version vX.Y.Z and add the release tag (example here)
    • make sure CHANGELOG.rst is up to date and enter current date to the release version
    • add summarized release highlights where appropriate
    • update the CITATION.cff version number and date
  • wait for review and the CI jobs to finish
  • check the readthedocs PR build

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #575 (24ddcf3) into master (ea5ead3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #575   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files          93       93           
  Lines        5768     5768           
=======================================
  Hits         5461     5461           
  Misses        307      307           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5ead3...24ddcf3. Read the comment docs.

@CagtayFabry CagtayFabry requested review from vhirtham and marscher and removed request for vhirtham October 7, 2021 10:46
@CagtayFabry CagtayFabry marked this pull request as ready for review October 7, 2021 12:42
@marscher
Copy link
Collaborator

marscher commented Oct 7, 2021

Python 3.10 has just arrived and unfortunately pip is broken (on conda-forge). I guess we could just wait until it is repaired upstream. Or we want to exclude 3.10 as it is not yet tested by our current matrix and is bleeding edge.

Anything weldx related looks great btw! 🚀

@CagtayFabry
Copy link
Member Author

Python 3.10 has just arrived and unfortunately pip is broken (on conda-forge). I guess we could just wait until it is repaired upstream. Or we want to exclude 3.10 as it is not yet tested by our current matrix and is bleeding edge.

Anything weldx related looks great btw! 🚀

Ah I see, let's wait till things cool down a bit 🙃

@marscher
Copy link
Collaborator

marscher commented Oct 8, 2021

I think we should add Py-3.10 to our matrix prior releasing and see what happens. Conda-forge will try to build it for this new version at least, so it'd be good to run the tests.

@marscher
Copy link
Collaborator

marscher commented Oct 8, 2021

Its a bug in conda, which truncates the major version to "3.1" instead of "3.10" and should be fixed soon (xref conda/conda#10970)

@CagtayFabry
Copy link
Member Author

good idea, I will rework the testing matrix a little over the weekend

@CagtayFabry CagtayFabry marked this pull request as draft October 11, 2021 17:06
@CagtayFabry CagtayFabry marked this pull request as ready for review October 12, 2021 09:04
@CagtayFabry
Copy link
Member Author

I have excluded support for 3.10 for now, please have a final look @vhirtham @marscher

Copy link
Collaborator

@marscher marscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Oct 12, 2021

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 17s ⏱️ -33s
1 902 tests ±0  1 902 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 24ddcf3. ± Comparison against base commit ea5ead3.

♻️ This comment has been updated with latest results.

@CagtayFabry CagtayFabry merged commit 4b1bdb9 into master Oct 12, 2021
@CagtayFabry CagtayFabry deleted the v0.5.0 branch October 12, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants