-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add weldx file wrapper #341
Conversation
Hello @marscher! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-04 13:18:20 UTC |
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 96.95% 96.89% -0.06%
==========================================
Files 85 87 +2
Lines 4993 5192 +199
==========================================
+ Hits 4841 5031 +190
- Misses 152 161 +9
Continue to review full report at Codecov.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cd'ing out of test source directory helps to solve this import conflict thing pytest raised, but now we have to decide how we proceed with the missing "scripts" folder. Currently the single_pass_weld.py is used as a fixture in several tests. When this is not deployed/installed, we should decide where to move these scripts, so that they can be used in an installed version of weldx. @CagtayFabry, @vhirtham what do you think where we should keep these scripts? |
If this is solved by #350 that's fine by me |
@@ -1335,3 +1336,17 @@ def compare_nested( | |||
|
|||
|
|||
compare_nested = _Eq_compare_nested.compare_nested | |||
|
|||
|
|||
def is_interactive_session() -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be really interested to see if/how we can distinguish between jupyter notebook/lab here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem to be possible as both environments seem to be equal from within the ipython object.
There has been a request to enable the display of JSON, but there was no response since last year. So I guess this has no priority at all. jupyter/notebook#5446
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get to review all code segments in detail but I think we should start using this as soon as possible to get a feel for it :)
Co-authored-by: vhirtham <[email protected]>
Co-authored-by: vhirtham <[email protected]>
Co-authored-by: vhirtham <[email protected]>
Co-authored-by: vhirtham <[email protected]>
A setter will never be rendered in sphinx, probably that's why.
|
You are right: https://stackoverflow.com/questions/17478040/how-can-i-generate-documentation-for-a-python-property-setter-using-sphinx Good to know. |
Unfortunately there is no way to determine, if a code is running in jupyterlab or notebook. So I suggest, we fall back to set use_widgets to false and lab users can enable it on their behalf. |
Changes
This adds an ASDF file wrapper to ease some
Features
Related Issues
Closes #271
Checks