Skip to content

Commit

Permalink
[Key Vault] Fix managed property in keys and secrets (Azure#22368)
Browse files Browse the repository at this point in the history
  • Loading branch information
mccoyp authored Feb 8, 2022
1 parent 5cb03b2 commit 94dff33
Show file tree
Hide file tree
Showing 6 changed files with 33 additions and 27 deletions.
11 changes: 4 additions & 7 deletions sdk/keyvault/azure-keyvault-administration/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
# Release History

## 4.1.0b3 (Unreleased)

### Features Added

### Breaking Changes

### Bugs Fixed
## 4.1.0b3 (2022-02-08)

### Other Changes
- Python 2.7 is no longer supported. Please use Python version 3.6 or later.
- Updated minimum `azure-core` version to 1.20.0
- (From 4.1.0b2) To support multi-tenant authentication, `get_token` calls during challenge
authentication requests now pass in a `tenant_id` keyword argument
([#20698](https://github.com/Azure/azure-sdk-for-python/issues/20698))

## 4.1.0b2 (2021-11-11)

Expand Down
11 changes: 4 additions & 7 deletions sdk/keyvault/azure-keyvault-certificates/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
# Release History

## 4.4.0b3 (Unreleased)

### Features Added

### Breaking Changes

### Bugs Fixed
## 4.4.0b3 (2022-02-08)

### Other Changes
- Python 2.7 is no longer supported. Please use Python version 3.6 or later.
- (From 4.4.0b2) To support multi-tenant authentication, `get_token` calls during challenge
authentication requests now pass in a `tenant_id` keyword argument
([#20698](https://github.com/Azure/azure-sdk-for-python/issues/20698))

## 4.4.0b2 (2021-11-11)

Expand Down
9 changes: 6 additions & 3 deletions sdk/keyvault/azure-keyvault-keys/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release History

## 4.5.0b6 (Unreleased)
## 4.5.0b6 (2022-02-08)

### Features Added
- Added `immutable` keyword-only argument and property to `KeyReleasePolicy` to support immutable
Expand All @@ -12,11 +12,14 @@
- Renamed the required argument `data` in `KeyReleasePolicy`'s constructor to
`encoded_policy`

### Bugs Fixed

### Other Changes
- Python 2.7 is no longer supported. Please use Python version 3.6 or later.
- Updated minimum `azure-core` version to 1.20.0
- Updated type hints for `KeyProperties` model's `managed`, `exportable`, and `release_policy`
properties ([#22368](https://github.com/Azure/azure-sdk-for-python/pull/22368))
- (From 4.5.0b5) To support multi-tenant authentication, `get_token` calls during challenge
authentication requests now pass in a `tenant_id` keyword argument
([#20698](https://github.com/Azure/azure-sdk-for-python/issues/20698))

## 4.5.0b5 (2021-11-11)

Expand Down
10 changes: 5 additions & 5 deletions sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,10 +225,10 @@ def tags(self):

@property
def managed(self):
# type: () -> bool
"""Returns whether the key's lifetime is managed by key vault
# type: () -> Optional[bool]
"""Whether the key's lifetime is managed by Key Vault. If the key backs a certificate, this will be true.
:rtype: bool
:rtype: bool or None
"""
return self._managed

Expand All @@ -237,7 +237,7 @@ def exportable(self):
# type: () -> Optional[bool]
"""Whether the private key can be exported
:rtype: bool
:rtype: bool or None
"""
# exportable was added in 7.3-preview
if self._attributes:
Expand All @@ -249,7 +249,7 @@ def release_policy(self):
# type: () -> Optional[KeyReleasePolicy]
"""The :class:`~azure.keyvault.keys.KeyReleasePolicy` specifying the rules under which the key can be exported.
:rtype: ~azure.keyvault.keys.KeyReleasePolicy
:rtype: ~azure.keyvault.keys.KeyReleasePolicy or None
"""
return self._release_policy

Expand Down
10 changes: 5 additions & 5 deletions sdk/keyvault/azure-keyvault-secrets/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
# Release History

## 4.4.0b3 (Unreleased)
## 4.4.0b3 (2022-02-08)

### Features Added

### Breaking Changes

### Bugs Fixed
- Added `managed` property to SecretProperties

### Other Changes
- Python 2.7 is no longer supported. Please use Python version 3.6 or later.
- (From 4.4.0b2) To support multi-tenant authentication, `get_token` calls during challenge
authentication requests now pass in a `tenant_id` keyword argument
([#20698](https://github.com/Azure/azure-sdk-for-python/issues/20698))

## 4.4.0b2 (2021-11-11)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,15 @@ def tags(self):
"""
return self._tags

@property
def managed(self):
# type: () -> Optional[bool]
"""Whether the secret's lifetime is managed by Key Vault. If the secret backs a certificate, this will be true.
:rtype: bool or None
"""
return self._managed


class KeyVaultSecret(object):
"""All of a secret's properties, and its value."""
Expand Down

0 comments on commit 94dff33

Please sign in to comment.