Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR sdk/containerinstance/mgmt-v2018_02_01_preview] [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 #3324

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions sdk/containerinstance/mgmt-v2018_02_01_preview/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@
<parent>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-arm-parent</artifactId>
<version>1.2.0</version>
<relativePath>../../parents/azure-arm-parent</relativePath>
<version>1.1.0</version>
<relativePath>../../../pom.management.xml</relativePath>
</parent>
<artifactId>azure-mgmt-containerinstance</artifactId>
<version>1.0.0-beta</version>
<packaging>jar</packaging>
<name>Microsoft Azure SDK for ContainerInstance Management</name>
<description>This package contains Microsoft ContainerInstance Management SDK.</description>
<url>https://github.com/Azure/azure-libraries-for-java</url>
<url>https://github.com/Azure/azure-sdk-for-java</url>
<licenses>
<license>
<name>The MIT License (MIT)</name>
Expand All @@ -28,8 +28,8 @@
</license>
</licenses>
<scm>
<url>scm:git:https://github.com/Azure/azure-libraries-for-java</url>
<connection>scm:git:[email protected]:Azure/azure-libraries-for-java.git</connection>
<url>scm:git:https://github.com/Azure/azure-sdk-for-java</url>
<connection>scm:git:[email protected]:Azure/azure-sdk-for-java.git</connection>
<tag>HEAD</tag>
</scm>
<properties>
Expand Down Expand Up @@ -71,6 +71,8 @@
<artifactId>azure-arm-client-runtime</artifactId>
<type>test-jar</type>
<scope>test</scope>
<!--Below version for test jar needs to be removed, this will be done as part of v1-runtime 1.6.7-->
<version>1.6.5</version>
</dependency>
</dependencies>
<build>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ interface WithGroup extends GroupableResourceCore.DefinitionStages.WithGroup<Wit
interface WithContainers {
/**
* Specifies containers.
*/
* @param containers The containers within the container group
* @return the next definition stage
*/
WithOsType withContainers(List<Container> containers);
}

Expand All @@ -103,46 +105,60 @@ interface WithContainers {
interface WithOsType {
/**
* Specifies osType.
*/
* @param osType The operating system type required by the containers in the container group. Possible values include: 'Windows', 'Linux'
* @return the next definition stage
*/
WithCreate withOsType(OperatingSystemTypes osType);
}

/**
* The stage of the containergroup update allowing to specify ImageRegistryCredentials.
* The stage of the containergroup definition allowing to specify ImageRegistryCredentials.
*/
interface WithImageRegistryCredentials {
/**
* Specifies imageRegistryCredentials.
* @param imageRegistryCredentials The image registry credentials by which the container group is created from
* @return the next definition stage
*/
WithCreate withImageRegistryCredentials(List<ImageRegistryCredential> imageRegistryCredentials);
}

/**
* The stage of the containergroup update allowing to specify IpAddress.
* The stage of the containergroup definition allowing to specify IpAddress.
*/
interface WithIpAddress {
/**
* Specifies ipAddress.
* @param ipAddress The IP address type of the container group
* @return the next definition stage
*/
WithCreate withIpAddress(IpAddress ipAddress);
}

/**
* The stage of the containergroup update allowing to specify RestartPolicy.
* The stage of the containergroup definition allowing to specify RestartPolicy.
*/
interface WithRestartPolicy {
/**
* Specifies restartPolicy.
* @param restartPolicy Restart policy for all containers within the container group.
- `Always` Always restart
- `OnFailure` Restart on failure
- `Never` Never restart
. Possible values include: 'Always', 'OnFailure', 'Never'
* @return the next definition stage
*/
WithCreate withRestartPolicy(ContainerGroupRestartPolicy restartPolicy);
}

/**
* The stage of the containergroup update allowing to specify Volumes.
* The stage of the containergroup definition allowing to specify Volumes.
*/
interface WithVolumes {
/**
* Specifies volumes.
* @param volumes The list of volumes that can be mounted by containers in this container group
* @return the next definition stage
*/
WithCreate withVolumes(List<Volume> volumes);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ public String apiVersion() {
return this.apiVersion;
}

/** Gets or sets the preferred language for the response. */
/** The preferred language for the response. */
private String acceptLanguage;

/**
* Gets Gets or sets the preferred language for the response.
* Gets The preferred language for the response.
*
* @return the acceptLanguage value.
*/
Expand All @@ -76,7 +76,7 @@ public String acceptLanguage() {
}

/**
* Sets Gets or sets the preferred language for the response.
* Sets The preferred language for the response.
*
* @param acceptLanguage the acceptLanguage value.
* @return the service client itself
Expand All @@ -86,11 +86,11 @@ public ContainerInstanceManagementClientImpl withAcceptLanguage(String acceptLan
return this;
}

/** Gets or sets the retry timeout in seconds for Long Running Operations. Default value is 30. */
/** The retry timeout in seconds for Long Running Operations. Default value is 30. */
private int longRunningOperationRetryTimeout;

/**
* Gets Gets or sets the retry timeout in seconds for Long Running Operations. Default value is 30.
* Gets The retry timeout in seconds for Long Running Operations. Default value is 30.
*
* @return the longRunningOperationRetryTimeout value.
*/
Expand All @@ -99,7 +99,7 @@ public int longRunningOperationRetryTimeout() {
}

/**
* Sets Gets or sets the retry timeout in seconds for Long Running Operations. Default value is 30.
* Sets The retry timeout in seconds for Long Running Operations. Default value is 30.
*
* @param longRunningOperationRetryTimeout the longRunningOperationRetryTimeout value.
* @return the service client itself
Expand All @@ -109,11 +109,11 @@ public ContainerInstanceManagementClientImpl withLongRunningOperationRetryTimeou
return this;
}

/** When set to true a unique x-ms-client-request-id value is generated and included in each request. Default is true. */
/** Whether a unique x-ms-client-request-id should be generated. When set to true a unique x-ms-client-request-id value is generated and included in each request. Default is true. */
private boolean generateClientRequestId;

/**
* Gets When set to true a unique x-ms-client-request-id value is generated and included in each request. Default is true.
* Gets Whether a unique x-ms-client-request-id should be generated. When set to true a unique x-ms-client-request-id value is generated and included in each request. Default is true.
*
* @return the generateClientRequestId value.
*/
Expand All @@ -122,7 +122,7 @@ public boolean generateClientRequestId() {
}

/**
* Sets When set to true a unique x-ms-client-request-id value is generated and included in each request. Default is true.
* Sets Whether a unique x-ms-client-request-id should be generated. When set to true a unique x-ms-client-request-id value is generated and included in each request. Default is true.
*
* @param generateClientRequestId the generateClientRequestId value.
* @return the service client itself
Expand Down Expand Up @@ -247,6 +247,6 @@ protected void initialize() {
*/
@Override
public String userAgent() {
return String.format("%s (%s, %s)", super.userAgent(), "ContainerInstanceManagementClient", "2018-02-01-preview");
return String.format("%s (%s, %s, auto-generated)", super.userAgent(), "ContainerInstanceManagementClient", "2018-02-01-preview");
}
}