Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GA api version 2022-11-01 exposing isSystemExtension and suppo… #199

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

Arif-lakhani
Copy link

…rt for plan info


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@Arif-lakhani Arif-lakhani marked this pull request as draft November 18, 2022 22:26
@Arif-lakhani Arif-lakhani force-pushed the ariflakhani/2022-11-01-GA branch from 852a34b to 7cb5215 Compare December 13, 2022 21:22
@Arif-lakhani Arif-lakhani marked this pull request as ready for review December 13, 2022 21:23
@Arif-lakhani Arif-lakhani force-pushed the ariflakhani/2022-11-01-GA branch from d6365b5 to 39ab7ff Compare December 13, 2022 21:31
Copy link
Collaborator

@NarayanThiru NarayanThiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm - you didn't make any change to the generated files under vendored_sdks, right?

@Arif-lakhani Arif-lakhani force-pushed the ariflakhani/2022-11-01-GA branch 5 times, most recently from 07405ef to 8f526a1 Compare December 20, 2022 20:20
@Arif-lakhani Arif-lakhani force-pushed the ariflakhani/2022-11-01-GA branch from 84b91d1 to 49e995a Compare January 12, 2023 18:10
@Arif-lakhani Arif-lakhani force-pushed the ariflakhani/2022-11-01-GA branch 4 times, most recently from 6a16945 to 0bb0b52 Compare January 12, 2023 21:05
@Arif-lakhani Arif-lakhani force-pushed the ariflakhani/2022-11-01-GA branch from 0bb0b52 to 97c808f Compare January 12, 2023 22:08
Copy link

@RamyasreeChakka RamyasreeChakka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

@RamyasreeChakka RamyasreeChakka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Arif-lakhani Arif-lakhani merged commit 2ff27e9 into k8s-extension/public Jan 20, 2023
@Arif-lakhani Arif-lakhani deleted the ariflakhani/2022-11-01-GA branch January 20, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants