New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to .net8 GA #2583

Merged

kllysng merged 1 commit into master from kellyyangsong/net8-GA

Nov 15, 2023

Contributor

kllysng commented Nov 14, 2023

No description provided.


          update to .net8 GA

1436da6

kllysng requested a review from jennyf19

November 14, 2023 23:48

ciaozhang approved these changes

View reviewed changes

keegan-caruso approved these changes

View reviewed changes

kllysng merged commit 0fb9929 into master

4 checks passed

kllysng deleted the kellyyangsong/net8-GA branch

November 15, 2023 00:32

Collaborator

jennyf19 commented Nov 15, 2023

A few places are missing:

microsoft-identity-web/tests/DevApps/Directory.Build.props

Line 23 in 665645c

<SystemDrawingCommon>8.0.0-rc.2.23479.14</SystemDrawingCommon>

microsoft-identity-web/tests/PerformanceTests/PerformanceTestService/PerformanceTestService.csproj

Line 23 in 665645c

<SystemDrawingCommon>8.0.0-rc.2.23479.14</SystemDrawingCommon>

Collaborator

jennyf19 commented Nov 15, 2023

https://github.com/AzureAD/microsoft-identity-web/blob/master/.github/workflows/dotnetcore.yml#L42

remove this:
https://github.com/AzureAD/microsoft-identity-web/blob/master/build/template-install-dependencies.yaml#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet