Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jmprieur/add ciam dev apps (address PR feedack) #2411

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

jmprieur
Copy link
Collaborator

Addressing PR feedback for #2399

- the CIAM authority is propagated to the options
- it's a v2.0 authority for JwtBearer
- The metadata endpoint is computed, including when extra query parameters.
…ions>

are done (that is in the JwtBearerOptionsMerger, which is a PostConfigure

Fixed a flaky test

Added code to initialize Playwright
@jmprieur jmprieur requested a review from jennyf19 August 30, 2023 03:36
@jennyf19
Copy link
Collaborator

for future reference: would be better to pull from main and start a fresh branch.

Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jmprieur jmprieur merged commit f1b31fc into master Aug 30, 2023
@jennyf19
Copy link
Collaborator

jennyf19 commented Sep 8, 2023

@jmprieur jmprieur deleted the jmprieur/addCiamDevApps branch October 12, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants