Kellyyangsong/net8 ga (#2584)

* update to .net8 GA * rm .net8-rc * change request * remove line
AzureAD · Nov 15, 2023 · efd1dec · efd1dec
1 parent 0fb9929
commit efd1dec
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/dotnetcore.yml b/.github/workflows/dotnetcore.yml
@@ -39,7 +39,7 @@ jobs:
     - name: Setup .NET 8.0.x
       uses: actions/[email protected]
       with:
-        dotnet-version: 8.0.100-rc.1.23463.5
+        dotnet-version: 8.0.x
 
     # Install workload
     - name: Setup wasm-tools

diff --git a/build/template-install-dependencies.yaml b/build/template-install-dependencies.yaml
@@ -22,8 +22,6 @@ steps:
   displayName: 'Use .Net Core SDK 8'
   inputs:
     version: 8.x  
-    includePreviewVersions: true
-  condition: eq(variables['TargetNet8'], 'True')
 
 # Run Nuget Tool Installer
 

diff --git a/tests/DevApps/Directory.Build.props b/tests/DevApps/Directory.Build.props
@@ -20,7 +20,7 @@
 
   <PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'">
     <!--CVE-2021-24112 from ASpNetCore.Protection, and Redis-->
-    <SystemDrawingCommon>8.0.0-rc.2.23479.14</SystemDrawingCommon>
+    <SystemDrawingCommon>8.0.0</SystemDrawingCommon>
   </PropertyGroup>
 
 </Project>
diff --git a/tests/PerformanceTests/PerformanceTestService/PerformanceTestService.csproj b/tests/PerformanceTests/PerformanceTestService/PerformanceTestService.csproj
@@ -20,7 +20,7 @@
 
   <PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'">
     <!--CVE-2021-24112 from ASpNetCore.Protection, and Redis-->
-    <SystemDrawingCommon>8.0.0-rc.2.23479.14</SystemDrawingCommon>
+    <SystemDrawingCommon>8.0.0</SystemDrawingCommon>
   </PropertyGroup>
 
   <ItemGroup>