Handle string time values when caching responses #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
approved these changes
Jun 11, 2019
There was a problem hiding this comment.
Talked to IMDS team and confirmed that they do have a long term plan to move to AAD v2 endpoint (which removes that "expires_in" as string behavior).
Meanwhile, we will take this PR as a workaround.
Also thanks @chlowell for fixing that "client_id could be None" issue in the key maker. That is a legit fix, and key maker is happy. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
response["expires_in"]is a string--as is the case for Azure Instance Metadata Service auth responses--lines 142 and 144 will raise because strings and integers can't be added. This change ensures all addends (now,expires_in,ext_expires_in) are integers.This also fixes an issue with the access token key maker. It accepts an optional
client_idbut when this is unspecified, the key maker passesNonetostr.join, which raises. I changed this to pass the empty string instead, as do other key makers.