Fix downstream ESM imports, fixes #6573

[rzyns]

Uses default import for importing keytar (a CJS module), which is really the only foolproof way of importing CJS from an ESM context.

I confirmed by creating a simple package:

// msal-node-extensions/foo/package.json
{ "type": "module" }

// msal-node-extensions/foo/index.js
import * as msal from "../dist/index.mjs";
msal;

Running node foo/index.mjs on dev gives the following error:

file:///.../microsoft-authentication-library-for-js/extensions/msal-node-extensions/dist/persistence/KeychainPersistence.mjs:3
import { setPassword, getPassword, deletePassword } from 'keytar';
                                   ^^^^^^^^^^^^^^
SyntaxError: Named export 'deletePassword' not found. The requested module 'keytar' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'keytar';
const { setPassword, getPassword, deletePassword } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)

Node.js v18.17.1

Running the same command on this branch succeeds (no output, exit code 0).

Not sure of a good/reliable way to encode that in an automated test, but I'd be happy to add one if anyone has any suggestions

[codecov-commenter]

Codecov Report

Merging #6600 (56b0d0f) into dev (81d34b4) will decrease coverage by 16.32%.
Report is 360 commits behind head on dev.
The diff coverage is 61.83%.

Flag	Coverage Δ
msal-angular	?
msal-browser	?
msal-common	?
msal-core	?
msal-node	?
msal-node-extensions	68.51% <61.57%> (-7.13%)	⬇️
msal-react	?
node-token-validation	?

Files	Coverage Δ
extensions/msal-node-extensions/src/Dpapi.ts	100.00% <100.00%> (ø)
.../msal-node-extensions/src/error/NativeAuthError.ts	100.00% <100.00%> (ø)
extensions/msal-node-extensions/src/index.ts	100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/packageMetadata.ts	100.00% <100.00%> (+100.00%)	⬆️
...-extensions/src/persistence/DataProtectionScope.ts	100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/utils/Constants.ts	100.00% <100.00%> (ø)
...sions/msal-node-extensions/src/utils/TypeGuards.ts	100.00% <100.00%> (ø)
...msal-node-extensions/src/error/PersistenceError.ts	62.50% <66.66%> (-11.58%)	⬇️
...node-extensions/src/persistence/BasePersistence.ts	64.28% <50.00%> (-2.39%)	⬇️
...e-extensions/src/persistence/PersistenceCreator.ts	91.42% <92.85%> (+0.25%)	⬆️
... and 8 more

... and 214 files with indirect coverage changes

[tnorling]

Thanks for the PR!

[konstantin-msft]

@rzyns please rebase onto base branch so we can merge this PR.