-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Andyohart/managed identity #532
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Readme suggestion update Co-authored-by: Bogdan Gavril <[email protected]>
https://github.com/AzureAD/microsoft-authentication-library-for-go into andyohart/managed-identity-basic-class-implementation
…-class-implementation Implement Initial API Classes
Added a simple version of getting token and printing it reformatting code.
Added tests and implementation for SAMI IMDS
Reverted changes in the test app
Formatting changes
Added method for UAMI
Updated the some code and cleaned up some comments and print statement
Updated the key for the resource Co-authored-by: Charles Lowell <[email protected]>
Updated the token from url function to a reaquest based function
…icrosoft-authentication-library-for-go into acquire-token-for-mise
Updated test to fail not only return error
Added tests for failure and success for SAMI
added context to request
Updated the tests to check for errors more correctly
Update some test and used mock.Client some refactoring for comments
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
…icrosoft-authentication-library-for-go into acquire-token-for-mise
Added Region auto enable in confidential client and its test
Removed Integration tests from github actions
The field isn't used anywhere. Removing it simplifies the work on introducing authority abstraction. We might re-add it once we need it for anything.
…ONCall Parsing the url, then setting qv.Encode() manually to u.RawQuery feel like an overcomplicated approach of creating url for http request. Use the native constructor, which enforces ctx to be passed into the request, and do simple sprintf for url + query.
This enables adding the same const for dSTS later in the process.
This allows reusing the function for dSTS flow.
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.