Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andyohart/managed identity #532

Closed
wants to merge 98 commits into from
Closed

Andyohart/managed identity #532

wants to merge 98 commits into from

Conversation

4gust
Copy link
Collaborator

@4gust 4gust commented Nov 8, 2024

No description provided.

AndyOHart and others added 30 commits August 21, 2024 08:30
* Readme suggestion update

Co-authored-by: Bogdan Gavril <[email protected]>
…-class-implementation

Implement Initial API Classes
Added a simple version of getting token and printing it
reformatting code.
Added tests and implementation for SAMI IMDS
Reverted changes in the test app
Formatting changes
Added method for UAMI
Updated the some code and cleaned up some comments and print statement
Updated the key for the resource

Co-authored-by: Charles Lowell <[email protected]>
Updated the token from url function to a reaquest based function
Updated test to fail not only return error
Added tests for failure and success for SAMI
added context to request
Updated the tests to check for errors more correctly
Update some test and used mock.Client
some refactoring for comments
4gust and others added 28 commits November 8, 2024 11:40
Added Region auto enable in confidential client and its test
Removed Integration tests from github actions
The field isn't used anywhere. Removing it simplifies the work on introducing
authority abstraction. We might re-add it once we need it for anything.
…t readability

Previously, the test results were printed as #0 #1 #2, which made it
hard to navigate the failed test cases. Now, the test cases
are annotated by their respective names. The names also make it
more clear what is being unit-tested.
…ONCall

Parsing the url, then setting qv.Encode() manually to u.RawQuery
feel like an overcomplicated approach of creating url for http request.

Use the native constructor, which enforces ctx to be
passed into the request, and do simple sprintf for url + query.
This enables adding the same const for dSTS later in the process.
This allows reusing the function for dSTS flow.
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@4gust 4gust closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants