-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds documentation for running IMDS locally #512
Conversation
AndyOHart
commented
Sep 25, 2024
- Adds a .md file for documenting how we run IMDS for System and User assigned
|
||
Firstly, to run IMDS locally, we need to change some files. | ||
|
||
1. Comment out everything in `client_certificate_sample.go` besides `package main` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we have a standalone sample for MSI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the existing code so we use our managedidentity_sample.go
2. In `sample_utils.go`, replace the Config struct with this | ||
|
||
``` | ||
type Config struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A standalone sample for MSI where this is file is preformatted would be better than docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the existing code so we use our managedidentity_sample.go
@@ -0,0 +1,162 @@ | |||
# Running the IMDS Source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to "msi_manual_test.md" ? It won't be just IMDS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please have a new dev app specifically for MSI.
ClientSecret string `json:"client_secret"` | ||
// Thumbprint string `json:"thumbprint"` | ||
// PemData string `json:"pem_file"` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove step 1 and 2 if we create a new folder for managed identity sample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your commenting on the outdated commit
edit
Sorry I saw you approved but this comment below it, those steps have been removed
Quality Gate passedIssues Measures |