small refactor

AzureAD · Oct 22, 2024 · f4194cf · f4194cf
1 parent 523d218
commit f4194cf
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/apps/managedidentity/managedidentity.go b/apps/managedidentity/managedidentity.go
@@ -259,15 +259,15 @@ func (client Client) AcquireToken(ctx context.Context, resource string, options
 
 	switch client.source {
 	case AzureArc:
-		return acquireAzureArc(ctx, client, resource, client.authParams)
+		return acquireAzureArc(ctx, client, resource)
 	case DefaultToIMDS:
-		return acquireIMDS(ctx, client, resource, client.authParams)
+		return acquireIMDS(ctx, client, resource)
 	default:
 		return base.AuthResult{}, fmt.Errorf("unsupported source %q", client.source)
 	}
 }
 
-func acquireIMDS(ctx context.Context, client Client, resource string, fakeAuthParams authority.AuthParams) (base.AuthResult, error) {
+func acquireIMDS(ctx context.Context, client Client, resource string) (base.AuthResult, error) {
 	req, err := createIMDSAuthRequest(ctx, client.miType, resource)
 	if err != nil {
 		return base.AuthResult{}, err
@@ -277,10 +277,10 @@ func acquireIMDS(ctx context.Context, client Client, resource string, fakeAuthPa
 	if err != nil {
 		return base.AuthResult{}, err
 	}
-	return authResultFromToken(fakeAuthParams, tokenResponse)
+	return authResultFromToken(client.authParams, tokenResponse)
 }
 
-func acquireAzureArc(ctx context.Context, client Client, resource string, fakeAuthParams authority.AuthParams) (base.AuthResult, error) {
+func acquireAzureArc(ctx context.Context, client Client, resource string) (base.AuthResult, error) {
 	req, err := createAzureArcAuthRequest(ctx, resource, "")
 	if err != nil {
 		return base.AuthResult{}, err
@@ -312,10 +312,6 @@ func acquireAzureArc(ctx context.Context, client Client, resource string, fakeAu
 	}
 	defer secondResponse.Body.Close()
 
-	if err != nil {
-		return base.AuthResult{}, err
-	}
-
 	responseBytes, err := io.ReadAll(secondResponse.Body)
 	if err != nil {
 		return base.AuthResult{}, fmt.Errorf("failed to read second azure arc response body: %w", err)