Add response_mode=form_post to legacy WebView authorization requests #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Jul 19, 2021
...ity.Client/Platforms/Features/WinFormsLegacyWebUi/WindowsFormsWebAuthenticationDialogBase.cs
Show resolved
Hide resolved
pmaytak
commented
Jul 19, 2021
...tity.Client/Platforms/Features/WinFormsLegacyWebUi/CustomWebBrowser.CustomWebBrowserEvent.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 19, 2021
pmaytak
commented
Jul 19, 2021
...ity.Client/Platforms/Features/WinFormsLegacyWebUi/WindowsFormsWebAuthenticationDialogBase.cs
Show resolved
Hide resolved
jennyf19
reviewed
Jul 19, 2021
....Identity.Client/Platforms/Features/WinFormsLegacyWebUi/WebBrowserBeforeNavigateEventArgs.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jul 19, 2021
src/client/Microsoft.Identity.Client/Platforms/Features/WinFormsLegacyWebUi/WebUI.cs
Show resolved
Hide resolved
|
tests? approving, but having some tests to cover the form_post would be good. |
trwalke
approved these changes
Jul 20, 2021
|
Seems like some tests on the build are also failing. |
This reverts commit b87fee4.
bgavrilMS
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2743, Fixes #2607, Fixes #2515, Fixes #2749.
Changes proposed in this request
Adding
response_mode=form_postto authorization URL only for requests using legacy WebView; so that the auth code and other response parameters are returned in the response body and not query.Testing
Unit tests + manual testing.
Performance impact
N/A