-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Stop using reflection to deserialize JSON #2403
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Feb 10, 2021
src/client/Microsoft.Identity.Client/OAuth2/MsalTokenResponse.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 10, 2021
bgavrilMS
reviewed
Feb 10, 2021
src/client/Microsoft.Identity.Client/Instance/Discovery/InstanceDiscoveryMetadataEntry.cs
Show resolved
Hide resolved
Looks good so far |
Great stuff. |
pmaytak
commented
Feb 12, 2021
src/client/Microsoft.Identity.Client/OAuth2/MsalTokenResponse.cs
Outdated
Show resolved
Hide resolved
pmaytak
force-pushed
the
pmaytak/json
branch
from
February 17, 2021 20:10
a1b77bc
to
36f3943
Compare
…iceCodeResponse, OAuth2ResponseBase. Add tests.
pmaytak
force-pushed
the
pmaytak/json
branch
from
February 24, 2021 05:10
55db5a8
to
a2adfb2
Compare
pmaytak
changed the title
Stop using reflection to deserialize JSON
[WIP] Stop using reflection to deserialize JSON
Feb 24, 2021
Went with #2428 as a solution as it's less invasive and more reliable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the possible solutions to #2343.
JSON.NET methods like
JObject.SerializeObject
,.DeserializeObject
,.ToObject
,.Value
use reflection. Updates code to serialize/deserialize objects by calling methods that don't use reflection, likeJObject[]
array indexers.(Also merges JsonUtils class into JsonHelpers.)
Perf test results
.NET Core 3.1.12 (CoreCLR 4.700.21.6504, CoreFX 4.700.21.6905), X86 RyuJIT