-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] enabling pii and euii data in logging & exceptions #4766
Comments
@gtsc - I am looking into this with the engineering team, thank you for bringing this up. |
@gtsc - Microsoft's official data classification is https://www.microsoft.com/en-us/trust-center/privacy/customer-data-definitions and it does not define EUII per se. EUII is an internal classification, used by some Microsoft products. With regards to exception messages:
With regards to EUII: MSAL.NET uses only "PII" flag, which includes EUII. |
@bgavrilMS Thanks for clarifying! I had a hard time understanding what falls under EUII when looking into that. Are you sure about the statement that enabling "PII" with the flag also shows all EUII unmasked?
|
I have a PR in our documentation that clarifies the PII/EUII handling. Referenced above. @bgavrilMS - I couldn't find any references to |
@localden Had a look and that definitely clarifies things. Let's make sure we can figure out where the I also had a quick look through the MSAL.NET code and couldn't really find any mention to |
@localden @gtsc - there are 2 components that MSAL uses:
|
@bgavrilMS Yes, I've been using the broker (WAM, so |
Documentation related to component
Logging
Please check those that apply
Description of the issue
I have a hard time finding information how to control masking of PII and EUII data in log messages and exceptions when using MSAL.NET.
The article on logging in MSAL has been of great help, but is lacking a few aspects:
enablePiiLogging
totrue
in.withLogging
will also influence the pii data being shown or hidden in messages in exceptions that MSAL throws. It would be helpful indicating that more clearly, as it isn't obvious that setting a variable that seems to only influence logging behaviour also influences exceptionsenablePiiLogging
set totrue
, the most sensitive information (EUII, like upn, name, email etc) will be hidden in log / exception messages, as they are replaced by{EUII Hidden}
. I couldn't find any information if it is possible to control how EUII data should be masked. The only information I could find was in a PR for MSAL for Objective-C, but I am not sure if this functionality is even part of MSAL.NET.The text was updated successfully, but these errors were encountered: