Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSAL to 4.65.0 #413

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Update MSAL to 4.65.0 #413

merged 2 commits into from
Nov 7, 2024

Conversation

Haard30
Copy link
Contributor

@Haard30 Haard30 commented Nov 6, 2024

MSAL < 4.64.0 has issues with authentication while using broker. Refer git-ecosystem/git-credential-manager#1617 (comment).

We plan to release new AzureAuth version soon, so it's good to get to the latest stable version.

Testing

Benchmarking

BenchmarkDotNet=v0.13.2, OS=Windows 11 (10.0.26100.2033)
Intel Core i7-10700 CPU 2.90GHz, 1 CPU, 16 logical and 8 physical cores
.NET SDK=8.0.403
  [Host]     : .NET 6.0.35 (6.0.3524.45918), X64 RyuJIT AVX2
  DefaultJob : .NET 6.0.35 (6.0.3524.45918), X64 RyuJIT AVX2


|                Method |     Mean |    Error |   StdDev |
|---------------------- |---------:|---------:|---------:|
| NativeBrokerBenchmark | 46.18 ms | 0.437 ms | 0.408 ms |

Other

azureauth --help
azureauth aad --help
azureauth ado pat --help
azureauth ado token --help
azureauth ado pat scopes --help
azureauth info --help
azureauth ado token
azureauth ado pat
azureauth aad (with different output and auth modes)

@Haard30 Haard30 requested a review from a team as a code owner November 6, 2024 23:35
@Haard30 Haard30 merged commit c784102 into main Nov 7, 2024
9 checks passed
@Haard30 Haard30 deleted the user/haashah/update-msal-version branch November 7, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants