-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AzureAuth to .NET 8 version #412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haard30
reviewed
Nov 4, 2024
mijpeterson
reviewed
Nov 6, 2024
Haard30
previously approved these changes
Nov 6, 2024
Haard30
approved these changes
Nov 7, 2024
reillysiemens
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Updated AzureAuth to .NET 8 version. I made these changes via the .NET Upgrade Assistant in Visual Studio 2022, which takes care of updating code and breaking changes if need be.
Updated AzureAuth to use the latest Lasso version
10.23.1
which is the version we get after upgrading Lasso to .NET 8.During testing, we also found out that currently AzureAuth is enabled with trimming, and we have always published the trimmed version of AzureAuth in the past. However, Lasso is not enabled with trimming, nor its dependency McMaster CommandLineUtils. Updating AzureAuth to .NET 8 makes it incompatible with Lasso and CommandLineUtils. So in order to finish updating version for now, we decide to disable trimming in AzureAuth.
Replaced the occurrences of win10-x64 with win-x64 in release yaml file and
bin\win\publish.cmd
. Will replace the occurrences of win10-x64 ininstall/install.ps1
after release is done.We were running into errors when testing with release pipeline:
It first failed at
Build Projects
step with errors like:"##[error]src\AdoPat.Test\AdoPat.Test.csproj(0,0): Error NU1900: Warning As Error: Error occurred while getting package vulnerability data: Unable to load the service index for source https://office.pkgs.visualstudio.com/DefaultCollection/_packaging/Office/nuget/v3/index.json."
To fix that, we had to add
ADO_TOKEN: $(System.AccessToken)
underBuild Projects
stepThen release pipeline failed at
Guardian Post analysis
step with error: BinSkim Error BA2021 https://office.visualstudio.com/OE/_build/results?buildId=32371389&view=resultsWe confirmed that this error was not introduced by our changes, because even main branch now would also run into this error https://office.visualstudio.com/OE/_build/results?buildId=32371389&view=results
This BinSkim Error BA2021 also seems to be a false positive according to Combability with .NET ReadyToRun and Self-Contained microsoft/binskim#970
After asking in the 1ESPT help channel, they suggested we can add a suppression file for the false positive https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/sdlanalysis/baselines
So we added a suppression file to the release pipeline
Also updated CHANGELOG to reflect all the changes.
Testing
Tested using the release pipeline to make sure it works
Tested following commands on both mac and windows: