-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dotnet path in mac publish script #401
Update dotnet path in mac publish script #401
Conversation
Out of curiosity, do we always install |
good question! based on my understanding, and please correct me if i am wrong: i dont think we are really installing So before this PR's change, in the |
To add to what Keyu mentioned, we don't install dotnet in any of the publish or dotnet scripts under the |
I see. that makes sense! approved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
The command
./bin/mac/publish
would throw error when i run it at the top level of the folder, for example/Users/keyuxuan/microsoft-authentication-cli
. The reason is that its using the globally installeddotnet
instead of thedotnet
underbin/mac
folder.Updating the dotnet to use the absolute path in mac publish script