Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1/2] Switch to official prod version #396

Merged
merged 5 commits into from
Jul 17, 2024
Merged

[1/2] Switch to official prod version #396

merged 5 commits into from
Jul 17, 2024

Conversation

Haard30
Copy link
Contributor

@Haard30 Haard30 commented Jul 8, 2024 •
edited
Loading

In this PR:

  1. We switch to official 1es pt.
  2. Add an explicit build step required by official pt for Roslyn analysis.
  3. Create a packaged directory to keep consistency in uploading artifacts with signing and packaging (and also to satisfy 1es requirement of uploading artifacts only as folders and not files (like .zip, .tar)).

@Haard30 Haard30 marked this pull request as ready for review July 8, 2024 18:44
@Haard30 Haard30 requested a review from a team as a code owner July 8, 2024 18:44
@Haard30 Haard30 changed the title Switch to official prod version [1/2] Switch to official prod version Jul 10, 2024
mvanchaa
mvanchaa previously approved these changes Jul 11, 2024
View reviewed changes
mvanchaa
mvanchaa previously approved these changes Jul 11, 2024
View reviewed changes
@Haard30 Haard30 requested a review from reillysiemens July 12, 2024 14:51
mijpeterson
mijpeterson reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@mijpeterson mijpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions

.github/workflows/release-azure-pipelines.yml Outdated Show resolved Hide resolved
.github/workflows/release-azure-pipelines.yml Show resolved Hide resolved
@Haard30 Haard30 merged commit 1457e03 into main Jul 17, 2024
9 checks passed
@Haard30 Haard30 deleted the user/haashah/use-official-prod-template branch July 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mijpeterson mijpeterson mijpeterson approved these changes

@mvanchaa mvanchaa mvanchaa approved these changes

@reillysiemens reillysiemens Awaiting requested review from reillysiemens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Haard30 @reillysiemens @mvanchaa @mijpeterson