Remove ESRP NuGet feed #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Office is a downstream of ESRP stream, which means we can always download `Microsoft.EsrpClient` from existing Office feed. By removing the feed and redirecting to Office, we no longer need to maintain 2 separate NuGet token. `ADO_TOKEN` will be enough.
goagain
added
the
devops
|
The only source of truth we have that this works is our Build pipeline in ADO indicating it can download ESRP stuff from office feed? We can't test in Github until we actually try to make a release? |
We can run release pipeline on this branch to validate. Remember don't hit the button. |
|
Well, that will be great validation to do. Make sure we let everyone in the team know to avoid hitting the button. |
goagain
requested review from
reillysiemens,
shalinikhare27,
Haard30,
Emilio0404 and
mvanchaa
mvanchaa
approved these changes
Nov 16, 2023
reillysiemens
approved these changes
Nov 17, 2023
Haard30
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Office is a downstream of ESRP stream, which means we can always download
Microsoft.EsrpClientfrom existing Office feed. By removing the feed and redirecting to Office, we no longer need to maintain 2 separate NuGet token.ADO_TOKENwill be enough.