-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AzureAuth Windows uninstall script #340
Conversation
@Emilio0404 - We can just edit the title as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Emilio0404, this is a great first AzureAuth PR. I have a couple of thoughts/questions for you, but overall I think you're on the right track. I think the biggest thing to sort out will be whether we can reasonably support uninstalling from custom locations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Emilio0404: I appreciate your willingness to keep iterating on this. It seems like you're still working through some of this, so feel free to consider a draft PR if you're not ready for more review.
I've left some more granular, but minor feedback after your last changes. At a high level I want to suggest that maybe you could just delete the entire default installation location instead of individually removing subdirectories thereof.
Basically, this:
- Discover all paths where AzureAuth might be.
- Just delete the entire
%LOCALAPPDATA%\Programs\AzureAuth
directory. - Clean up paths you deleted from
%PATH%
(these will be subdirectories of the above). - Output that you've uninstalled AzureAuth.
- As a courtesy, output non-overlapping paths from step 1 (things you can't actually safely delete).
I think this might simplify some of your current logic.
@mvanchaa, @shalinikhare27, @Haard30: Would love your feedback on the above steps. ☝️
5d85ae3
Added a script to uninstall AzureAuth easily. The script handles the removal of the default AzureAuth installation folder, and updates the PATH to not contain any references to AzureAuth.
Right now, it was tested manually, but integration tests are coming soon.
From issue: #121