Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lasso and use incognito mode. #187

Merged
merged 18 commits into from
Feb 8, 2023
Merged

Conversation

goagain
Copy link
Contributor

@goagain goagain commented Jan 27, 2023

To achieve privacy compliance, AzureAuth need to stop collecting EUII data, such as alias, device name.
This PR will use the functionality that Lasso provides.

To make sure we are still able to support our customer, subcommand info is added.
Run azureauth info will get the following output:

AzureAuth Version: 1.0.0.0
Device ID: 13e6409f-d18d-4e67-9644-b28efe9fc607
To reset your device identifier, Run `azureauth info reset-device-id`

Also, the helper text is added in help manual azureauth --help:

Commands:
  info           Show debug information of AzureAuth. Please provide when asking for help.

@goagain goagain added the enhancement New feature or request label Jan 27, 2023
@goagain goagain requested a review from a team as a code owner January 27, 2023 22:52
@goagain goagain self-assigned this Jan 27, 2023
Copy link
Contributor

@shalinikhare27 shalinikhare27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First look!

src/AzureAuth/OutputMode.cs Outdated Show resolved Hide resolved
src/AzureAuth/ExceptionListToStringConverter.cs Outdated Show resolved Hide resolved
src/AzureAuth/CommandMain.cs Outdated Show resolved Hide resolved
src/AzureAuth/CommandInfo.cs Outdated Show resolved Hide resolved
src/AzureAuth/CommandInfo.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@kyle-rader kyle-rader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design question.

src/AzureAuth/OutputMode.cs Outdated Show resolved Hide resolved
@goagain goagain force-pushed the users/ruitang/upgrade_lasso branch from e284e08 to 913f69b Compare February 3, 2023 20:16
Copy link
Member

@reillysiemens reillysiemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goagain: Overall, I think this is looking great! Very clean code here. However, I think we should add some tests.

Copy link
Contributor

@kyle-rader kyle-rader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goagain I beleive the core business logic doesn't warrent unit tests, because it's mostly just a new CLI command, and printing some info. Managing the Machine ID itself, is worth unit testing, and that is owned by Lasso.

After seeing that interface in use here, I think it would benfit us to make an update in Lasso, to handle fully unit testing the "MachineIDHelper" class. That class can have a more complete interface that handles all this.

Copy link
Contributor

@kyle-rader kyle-rader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 1 last design question :)

src/AzureAuth/CommandInfo.cs Outdated Show resolved Hide resolved
@goagain goagain requested a review from kyle-rader February 8, 2023 01:14
Copy link
Contributor

@kyle-rader kyle-rader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few final suggestions on formatting and wording.

src/AzureAuth/Commands/CommandInfo.cs Outdated Show resolved Hide resolved
src/AzureAuth/Commands/Info/CommandInfoResetDeviceID.cs Outdated Show resolved Hide resolved
src/AzureAuth/Commands/Info/CommandInfoResetDeviceID.cs Outdated Show resolved Hide resolved
@goagain goagain merged commit 4bd0d97 into main Feb 8, 2023
@goagain goagain deleted the users/ruitang/upgrade_lasso branch February 8, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants