Remove IWA from default auth modes. (#415)

* Remove IWA from default auth modes.

* Fix unit tests which were expected to break

CHANGELOG.md

@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Removed
+- Removed IWA from default authentcation mode.
 ### Changed
 - Temporarily paused the publishing of Linux binaries.
 - Upgrade MSAL from `4.59.1` to `4.65.0`.

src/AzureAuth.Test/AuthModeExtensionsTest.cs

@@ -38,7 +38,7 @@ public void CombinedAuthMode_Allowed()
             this.envMock.Setup(e => e.Get(EnvVars.NoUser)).Returns(string.Empty);
             this.envMock.Setup(e => e.Get("Corext_NonInteractive")).Returns(string.Empty);
 
-            var subject = new[] { AuthMode.IWA, AuthMode.Web, AuthMode.Broker };
+            var subject = new[] { AuthMode.Web, AuthMode.Broker };
 
             // Act + Assert
             subject.Combine().PreventInteractionIfNeeded(this.envMock.Object, this.logger).Should().Be(AuthMode.Default);

src/AzureAuth/Commands/CommandAad.cs

@@ -61,7 +61,7 @@ public class CommandAad
         /// </summary>
 #if PlatformWindows
         public const string AuthModeHelperText = @"Authentication mode. Repeated invocations allowed.
-[default: iwa (Integrated Windows Auth), then broker, then web]
+[default: broker, then web]
 [possible values: all, iwa, broker, web, devicecode]";
 #else
         public const string AuthModeHelperText = @"Authentication mode. Repeated invocations allowed. [default: web]

src/MSALWrapper.Test/AuthFlow/AuthFlowFactoryTest.cs

@@ -111,37 +111,33 @@ public void Broker_Only()
         [Test]
         public void Windows10Or11_Defaults()
         {
-            this.MockIsWindows(true);
             this.MockIsWindows10Or11(true);
 
             IEnumerable<IAuthFlow> subject = this.Subject(AuthMode.Default);
 
-            subject.Should().HaveCount(4);
+            subject.Should().HaveCount(3);
             subject
                 .Select(a => a.GetType())
                 .Should()
                 .ContainInOrder(
                     typeof(CachedAuth),
-                    typeof(IntegratedWindowsAuthentication),
                     typeof(Broker),
                     typeof(Web));
         }
 
         [Test]
         public void Windows_Defaults()
         {
-            this.MockIsWindows(true);
             this.MockIsWindows10Or11(false);
 
             IEnumerable<IAuthFlow> subject = this.Subject(AuthMode.Default);
 
-            subject.Should().HaveCount(3);
+            subject.Should().HaveCount(2);
             subject
                 .Select(a => a.GetType())
                 .Should()
                 .ContainInOrder(
                     typeof(CachedAuth),
-                    typeof(IntegratedWindowsAuthentication),
                     typeof(Web));
         }
 
@@ -159,7 +155,6 @@ public void Windows10Or11_All()
                 .Should()
                 .ContainInOrder(
                     typeof(CachedAuth),
-                    typeof(IntegratedWindowsAuthentication),
                     typeof(Broker),
                     typeof(Web),
                     typeof(DeviceCode));

src/MSALWrapper.Test/AuthModeTest.cs

@@ -22,9 +22,9 @@ public void AllIsAll()
         public void WindowsDefaultModes()
         {
             var subject = AuthMode.Default;
-            subject.IsIWA().Should().BeTrue();
             subject.IsBroker().Should().BeTrue();
             subject.IsWeb().Should().BeTrue();
+            subject.IsIWA().Should().BeFalse();
             subject.IsDeviceCode().Should().BeFalse();
         }
 

src/MSALWrapper/AuthMode.cs

@@ -47,7 +47,7 @@ public enum AuthMode : short
         /// <summary>
         /// Default auth mode.
         /// </summary>
-        Default = IWA | Broker | Web,
+        Default = Broker | Web,
 #else
         /// <summary>
         /// All auth modes.