This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
fix an incorrect cache operation on authorization code flow #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
approved these changes
Jun 26, 2018
There was a problem hiding this comment.
Thanks @yugangw-msft for catching this issue. @abhidnya13 and I have reviewed this change together and understand the rationale of this change.
abhidnya13
approved these changes
Jun 26, 2018
There was a problem hiding this comment.
After conversation with @rayluo about the cache logic, I understand what the change is. LGTM
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//CC: @rayluo
My Change #138 was not right by searching the cache before sending out the request because at that time we don't know the userID, so the entry returned from cache might be issued to other users.
So I am reverting it and replace with the right fix, which is one line change like we did on device code
The unit test introduce by #138 is still kept as it verifies the right scenario, that the token from the wire response will be saved in cache.