This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
Potential null ref fix when instance discovery fails #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
commented
Jun 6, 2019
| @@ -46,6 +47,52 @@ public void Initialize() | |||
| InstanceDiscovery.InstanceCache.Clear(); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public async Task Double504Async() | |||
There was a problem hiding this comment.
Sadly this test, as well as repeated attempts to repro this with Fiddler AutoResponder, fail to repro the issue.
jennyf19
approved these changes
Jun 6, 2019
MarkZuber
reviewed
Jun 6, 2019
| @@ -101,7 +101,8 @@ internal virtual HttpClient GetHttpClient() | |||
|
|
|||
| private HttpRequestMessage CreateRequestMessage(Uri endpoint, IDictionary<string, string> headers) | |||
| { | |||
| HttpRequestMessage requestMessage = new HttpRequestMessage { RequestUri = endpoint }; | |||
| HttpRequestMessage requestMessage = new HttpRequestMessage { | |||
There was a problem hiding this comment.
nit: please fix formatting, no { on same line.
MarkZuber
approved these changes
Jun 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix and more logging for #1610