Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Warning Quality Check Build Task 🔨 #3067

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Add Warning Quality Check Build Task 🔨 #3067

merged 2 commits into from
Dec 20, 2024

Conversation

kellyyangsong
Copy link
Contributor

With the new task, I've configured the build to:

  • fail if the number of warnings has increased since the previous build - no new warnings!
  • show warning statistics to show the changes in number of warnings grouped by task/code file/object

I have not selected this option:

  • Force fewer warnings
  • Allow Variance - we don't want the number of warnings to creep up.

Build Quality Checks Warnings Policy documentation: https://github.com/MicrosoftPremier/VstsExtensions/blob/master/BuildQualityChecks/en-US/WarningsPolicy.md#evaluateTaskWarnings

@kellyyangsong kellyyangsong requested a review from a team as a code owner December 19, 2024 23:22
jmprieur
jmprieur approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @kellyyangsong

jennyf19
jennyf19 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome.

:shipit:

@kellyyangsong kellyyangsong merged commit c75a8f2 into dev Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellyyangsong @jmprieur @jennyf19