Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect TVP.RequireAudience when set to false #3055

Merged
merged 6 commits into from
Dec 14, 2024

Conversation

kellyyangsong
Copy link
Contributor

Addresses #1547

Since I was modifying the tests that used AudienceValidationTheoryData, I updated it to include testId parameter in the ctor.

@kellyyangsong kellyyangsong requested a review from a team as a code owner December 10, 2024 01:11
@sruke
Copy link
Contributor

sruke commented Dec 12, 2024

Consider updating the comment on the RequireAudience property.

@kellyyangsong
Copy link
Contributor Author

kellyyangsong commented Dec 13, 2024

Consider updating the comment on the RequireAudience property.

Updated, please let me know it isn't satisfactory

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @kellyyangsong

@sruke sruke linked an issue Dec 14, 2024 that may be closed by this pull request
@kellyyangsong kellyyangsong merged commit ebcc58b into dev Dec 14, 2024
6 checks passed
@kellyyangsong kellyyangsong deleted the kellysong/respect-require-aud branch December 14, 2024 07:23
@kellyyangsong kellyyangsong added this to the 8.3.1 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token validation does not use require audience parameter
4 participants