Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lazy ClaimsIdentity creation from ValidatedToken on SAML and SAML2 on the new validation model #3051

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Implement lazy ClaimsIdentity creation from ValidatedToken on SAML and SAML2 on the new validation model #3051

merged 6 commits into from
Dec 9, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Dec 4, 2024 •
edited
Loading

Implement lazy ClaimsIdentity creation from ValidatedToken on SAML and SAML2

  • Implemented the ClaimsIdentity creation methods to allow ValidatedToken to lazily create the claims when accessed in SAML and SAML2 token handlers.
  • Updated new validation model on SAML and SAML2 to return the validated fields as part of ValidatedToken
  • Added tests to compare the ClaimsIdentity returned in the legacy path against the new one

Part of #2711

@iNinja iNinja marked this pull request as ready for review December 5, 2024 20:12
@iNinja iNinja requested a review from a team as a code owner December 5, 2024 20:12
@iNinja iNinja changed the title Implement lazy ClaimsIdentity creation from ValidatedToken on SAML and SAML2 Implement lazy ClaimsIdentity creation from ValidatedToken on SAML and SAML2 on the new validation model Dec 5, 2024
@iNinja iNinja merged commit 039e8f8 into dev Dec 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westin-m westin-m westin-m approved these changes

@kellyyangsong kellyyangsong kellyyangsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iNinja @kellyyangsong @westin-m