-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request count and duration telemetry #3022
Conversation
src/Microsoft.IdentityModel.Logging/IdentityModelTelemetryUtil.cs
Outdated
Show resolved
Hide resolved
…zure-activedirectory-identitymodel-extensions-for-dotnet into westin/clientTelemetry
…zure-activedirectory-identitymodel-extensions-for-dotnet into westin/clientTelemetry
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Logging/IdentityModelTelemetryUtil.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Logging/IdentityModelTelemetryUtil.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/ConfigurationManagerTelemetryTests.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/ConfigurationManagerTelemetryTests.cs
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Logging/IdentityModelTelemetryUtil.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateToken.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Logging/ConfigurationManagerTelemetryInstrumentation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asking for layering changes.
src/Microsoft.IdentityModel.Tokens/Telemetry/TelemetryInstrumentation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Logging/Microsoft.IdentityModel.Logging.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Telemetry/IdentityModelTelemetry.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Telemetry/ITelemetryInstrumentation.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some naming.
Code should live in assembly where dependencies are included.
Why do we need an interface?
src/Microsoft.IdentityModel.Tokens/Telemetry/TelemetryConstants.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Telemetry/IdentityModelTelemetry.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Telemetry/TelemetryInstrumentation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Telemetry/TelemetryConstants.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandlerTelemetryTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Telemetry/IdentityModelTelemetry.cs
Outdated
Show resolved
Hide resolved
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
src/Microsoft.IdentityModel.Tokens/Telemetry/IdentityModelTelemetry.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Telemetry/TelemetryClient.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Keegan <Keegan.Caruso@microsoft.com>
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest putting telemetry code in M.IM.Logging assembly.
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
Addresses client telemetry repair item
Add counter for get configuration requests and histogram for total duration of the same requests.