-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidating test statics #2956
Conversation
SummarySummary
CoverageMicrosoft.IdentityModel.Abstractions - 70.2%
Microsoft.IdentityModel.JsonWebTokens - 79.9%
Microsoft.IdentityModel.Logging - 74.9%
Microsoft.IdentityModel.Protocols - 88.2%
Microsoft.IdentityModel.Protocols.OpenIdConnect - 81.4%
Microsoft.IdentityModel.Protocols.SignedHttpRequest - 93.4%
Microsoft.IdentityModel.Protocols.Tests - 0%
Microsoft.IdentityModel.Protocols.WsFederation - 80.9%
Microsoft.IdentityModel.TestUtils - 86.9%
Microsoft.IdentityModel.Tokens - 75.9%
Microsoft.IdentityModel.Tokens.Saml - 70.8%
Microsoft.IdentityModel.Tokens.Tests - 4.6%
Microsoft.IdentityModel.Validators - 95.8%
Microsoft.IdentityModel.Xml - 80.6%
System.IdentityModel.Tokens.Jwt - 83.7%
System.IdentityModel.Tokens.Jwt.Tests - 20.1%
|
Looks like the tests are failing do they work locally? |
SummarySummary
CoverageMicrosoft.IdentityModel.Abstractions - 70.2%
Microsoft.IdentityModel.JsonWebTokens - 79.9%
Microsoft.IdentityModel.Logging - 74.5%
Microsoft.IdentityModel.Protocols - 88.2%
Microsoft.IdentityModel.Protocols.OpenIdConnect - 81.4%
Microsoft.IdentityModel.Protocols.SignedHttpRequest - 93.4%
Microsoft.IdentityModel.Protocols.Tests - 0%
Microsoft.IdentityModel.Protocols.WsFederation - 80.9%
Microsoft.IdentityModel.TestUtils - 86.9%
Microsoft.IdentityModel.Tokens - 75.9%
Microsoft.IdentityModel.Tokens.Saml - 71%
Microsoft.IdentityModel.Tokens.Tests - 4.6%
Microsoft.IdentityModel.Validators - 95.8%
Microsoft.IdentityModel.Xml - 80.6%
System.IdentityModel.Tokens.Jwt - 83.7%
System.IdentityModel.Tokens.Jwt.Tests - 20.1%
|
hmmm...I thought we were trying to remove the flakiness? 🎃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment, non-blocking
Oh for sure, but that flakiness is coming from somewhere else in the code/build infrastructure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Travis
Consolidating test statics
Summary of the changes (Less than 80 chars)
Description
The issue here is that there are 2 statics that have the same data and are supposed to be kept in sync. However, this is quite tedious and if a change is made unknowingly to one of the static pairs, it can be challenging to find the issue when tests fail during comparisons. This PR attempts to consolidate the static pairs into one source and the different forms of the statics can be acquired though subsequent properties.
Fixes #2272