Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds on macOS / Linux using the build.sh script #2937

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

filipnavara
Copy link
Contributor

Fix builds on macOS / Linux using the build.sh script

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

The builds are broken on macOS / Linux due to references to non-existing files and tests being compiled against wrong assets (eg. net6+ tests with Span APIs trying to use netstandard2.0 assets).

@filipnavara filipnavara requested a review from a team as a code owner October 23, 2024 22:06
build.sh Show resolved Hide resolved
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @filipnavara

@jennyf19
Copy link
Collaborator

Thanks so much @filipnavara

@jennyf19 jennyf19 added this to the 8.2.0 milestone Oct 24, 2024
@jennyf19 jennyf19 merged commit 8536e07 into AzureAD:dev Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants