Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests: Token Replay #2931

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Oct 23, 2024

Regression tests: Token Replay

  • Removed calls to MarkAsUnsafeSecurityArtifact in the new path as they were printing the tokens in clear text and we cannot use JwtTokenUtilities.SafeLogJwt due to the fact that this handles other SecurityTokens as well. This way the logger still masks the token as a SecurityArtifact.
  • Aligned returned exception when token has no expiration and token cache is set to match legacy path.
  • Added regression/comparison tests for token replay scenarios

Resolves #2915

Part of #2711

…e tokens in clear text and we cannot use JwtTokenUtilities.SafeLogJwt due to the fact that this handles other SecurityTokens as well.
@iNinja iNinja requested a review from a team as a code owner October 23, 2024 11:34
@iNinja iNinja merged commit 788a7a4 into dev Oct 24, 2024
5 checks passed
@iNinja iNinja deleted the iinglese/regression-tests-token-replay branch November 15, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comparison tests for Token Replay validation in new validation model
4 participants