Added properties to ValidationResult without throwing #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyf19
approved these changes
Oct 17, 2024
| get | ||
| { | ||
| if (IsValid) | ||
| LogHelper.LogWarning("Warning: Accessing the Error property in a valid result is invalid."); |
There was a problem hiding this comment.
nit: I wonder if we should have this as an IDX message?
There was a problem hiding this comment.
I'll raise an issue to review the messages and look into that as well.
iNinja
deleted the
iinglese/add-non-throwing-properties-to-validation-result
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added properties to ValidationResult without throwing
ValidationResultwithout throwing exceptions.Part of #2711